[Webkit-unassigned] [Bug 171720] [preload] Add media and type attribute support.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 20 16:24:19 PDT 2017


--- Comment #22 from youenn fablet <youennf at gmail.com> ---
> On second thought, since loadLinksFromHeader is static, I think it's better
> to avoid it keeping state. Would changing the parameter name to
> MediaAttributeCheck with the values of MediaAttributeEmpty and
> MediaAttributeNotEmpty make it clearer?

Oh right!
It seems that we are mixing two things with LinkLoader: actually load of a link element and preloading stuff. That is not easy to understand.
Having preloadIfNeeded return a unique_ptr that is used only in one case seems very strange too.

It seems like all the preloading stuff should be done either in Document, CachedResourceLoader or in its own class that the CachedResourceLoader would own.
Last option would make things much easier to reason about.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170520/1918fbbb/attachment.html>

More information about the webkit-unassigned mailing list