[Webkit-unassigned] [Bug 171720] [preload] Add media and type attribute support.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171720

--- Comment #21 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to Yoav Weiss from comment #20)
> (In reply to youenn fablet from comment #19)
> > Comment on attachment 310652 [details]
> > Patch
> > 
> > 
> > > Source/WebCore/loader/LinkLoader.cpp:89
> > > +void LinkLoader::loadLinksFromHeader(const String& headerValue, const URL& baseURL, Document& document, PreloadLinkType preloadLinkType)
> > 
> > This parameter was not very clear to me at first.
> > A suggestion to make things clearer:
> > Might be clearer to have loadLinksFromHeader with the 3 current parameters
> > and loadMediaLinksIfAny() with no parameters.
> > loadLinksFromHeader would store any useful media header set for
> > loadMediaLinksIfAny
> 
> Fair enough. Will do
> 

On second thought, since loadLinksFromHeader is static, I think it's better to avoid it keeping state. Would changing the parameter name to MediaAttributeCheck with the values of MediaAttributeEmpty and MediaAttributeNotEmpty make it clearer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170520/dd859811/attachment.html>