[Webkit-unassigned] [Bug 172266] REGRESSION (new media controls): backdrops appear with visibility:hidden, showing new media controls when it shouldn't on apple.com

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 18 08:40:10 PDT 2017


--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 310501
  --> https://bugs.webkit.org/attachment.cgi?id=310501

View in context: https://bugs.webkit.org/attachment.cgi?id=310501&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1640
> +    bool needBackdropLayerType = (customAppearance() == LightBackdropAppearance || customAppearance() == DarkBackdropAppearance) && m_contentsVisible;

It's a bit weird to change the layer type based on visibility. What's the actual problem here; does CA still do backdrop stuff on layers with the hidden attribute, or do we fail to set the hidden attribute on some of the layers we create?

> LayoutTests/compositing/visibility/visibility-custom-backdrop-appearance.html:74
> +    toggle.offsetWidth;

Why do you need to force layout?

> LayoutTests/compositing/visibility/visibility-custom-backdrop-appearance.html:75
> +    toggle.classList.toggle("hidden");

You could just put a class on document.body and rewrite the selectors.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170518/480d58da/attachment.html>

More information about the webkit-unassigned mailing list