[Webkit-unassigned] [Bug 172266] REGRESSION (new media controls): backdrops appear with visibility:hidden, showing new media controls when it shouldn't on apple.com

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 18 08:50:26 PDT 2017


--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---

> It's a bit weird to change the layer type based on visibility. What's the
> actual problem here; does CA still do backdrop stuff on layers with the
> hidden attribute, or do we fail to set the hidden attribute on some of the
> layers we create?

Custom backdrop layer replaces m_layer and for m_layer we just null out the content (and call setContentsHidden which doesn't do much) instead of calling setHidden. Visible stuff on backdrop layer is not content so we fail to hide it.

The logic here is that we don't need backdrop layer at all when it is not visible.

> > LayoutTests/compositing/visibility/visibility-custom-backdrop-appearance.html:74
> > +    toggle.offsetWidth;
> Why do you need to force layout?

I wanted to ensure that there is a mutation in the layer tree. I'm not actually sure if this is sufficient for that.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170518/0bdc55cf/attachment.html>

More information about the webkit-unassigned mailing list