[Webkit-unassigned] [Bug 171745] WebKit should maintain colorspaces that it understands on NSColors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171745

--- Comment #4 from Beth Dakin <bdakin at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 309201 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309201&action=review
> 
> > Source/WebCore/platform/graphics/mac/ColorMac.mm:64
> > +    if (color.colorSpace == [NSColorSpace sRGBColorSpace])
> 
> This should use isEqual(To?): right?
> 

Yup, fixing.

> > Source/WebCore/platform/graphics/mac/ColorMac.mm:67
> > +        rgbColor = [color colorUsingColorSpaceName:NSDeviceRGBColorSpace];
> 
> Is this equivalent to NSCalibratedRGBColorSpace and which is sRGB?

I'm not sure. This is what we have always done in this function before this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170505/9cdb3af3/attachment-0001.html>