[Webkit-unassigned] [Bug 171745] WebKit should maintain colorspaces that it understands on NSColors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171745

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309201|review+                     |review?
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309201
  --> https://bugs.webkit.org/attachment.cgi?id=309201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309201&action=review

> Source/WebCore/platform/graphics/mac/ColorMac.mm:64
> +    if (color.colorSpace == [NSColorSpace sRGBColorSpace])

This should use isEqual(To?): right?

> Source/WebCore/platform/graphics/mac/ColorMac.mm:67
> +        rgbColor = [color colorUsingColorSpaceName:NSDeviceRGBColorSpace];

Is this equivalent to NSCalibratedRGBColorSpace and which is sRGB?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170505/c66d75f7/attachment.html>