[Webkit-unassigned] [Bug 171602] REGRESSION(r215686): Incremental reads from SharedBuffer are wrong after r215686

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 3 16:59:41 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=171602

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 308899
  --> https://bugs.webkit.org/attachment.cgi?id=308899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308899&action=review

> Source/WebCore/loader/TextTrackLoader.cpp:103
> -        m_cueParser->parseBytes(segment->data() + bytesToSkip, segment->size() - bytesToSkip);
> +        auto bytesToUse = segment->size() - bytesToSkip;
> +        m_cueParser->parseBytes(segment->data() + bytesToSkip, bytesToUse);
>          bytesToSkip = 0;
> -        m_parseOffset += segment->size();
> +        m_parseOffset += bytesToUse;

There doesn't seem to be a test for this part of the patch. What does this fix?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170503/657f2d8b/attachment-0001.html>


More information about the webkit-unassigned mailing list