[Webkit-unassigned] [Bug 171450] Add a new function for getting the Git hash for a pure git directory.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 1 09:52:07 PDT 2017


--- Comment #5 from Jason Marcell <jmarcell at apple.com> ---
Comment on attachment 308595
  --> https://bugs.webkit.org/attachment.cgi?id=308595

View in context: https://bugs.webkit.org/attachment.cgi?id=308595&action=review

>>> Tools/Scripts/VCSUtils.pm:456
>>> +        $command = "LC_ALL=C $command" if !isWindows();
>> Curious what is this for?
> I'm not sure. It's some copy pasta from `svnRevisionForDirectory`. You're right to question it. We should figure out if we even need it here before landing.

I've done some research. Why do this?
>From here: https://unix.stackexchange.com/a/87763

We're setting the locale to something generic in this case because the returned data is not intended for human consumption and, thus, does not need locale specific interpretation.

> Any time where you process input data or output data that is not intended from/for a human. If you're talking to a user, you may want to use their convention and language, but for instance, if you generate some numbers to feed some other application that expects English style decimal points, or English month names, you'll want to set LC_ALL=C

Why are we excluding Windows?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170501/bb065e53/attachment.html>

More information about the webkit-unassigned mailing list