[Webkit-unassigned] [Bug 170316] WebAssembly: Ref count Signature and SignatureInformation should not care about VM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 31 11:57:59 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170316

--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 305943
  --> https://bugs.webkit.org/attachment.cgi?id=305943
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305943&action=review

>>> Source/JavaScriptCore/wasm/WasmSignature.cpp:77
>>> +    void* memory = Signature::operator new (allocatedSize(argumentCount));
>> 
>> Other parts of the code use the try* allocators so that wasm can OOM without being sad. It was tryFastCalloc above, we should keep that property here.
> 
> Ok.

Actually, Ima keep this as is. Our handling of an argument count limit should make tryMalloc here useless. We should enforce our own limit during module parsing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170331/5668b1d1/attachment-0001.html>


More information about the webkit-unassigned mailing list