<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebAssembly: Ref count Signature and SignatureInformation should not care about VM"
href="https://bugs.webkit.org/show_bug.cgi?id=170316#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebAssembly: Ref count Signature and SignatureInformation should not care about VM"
href="https://bugs.webkit.org/show_bug.cgi?id=170316">bug 170316</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=305943&action=diff" name="attach_305943" title="patch">attachment 305943</a> <a href="attachment.cgi?id=305943&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=305943&action=review">https://bugs.webkit.org/attachment.cgi?id=305943&action=review</a>
<span class="quote">>>> Source/JavaScriptCore/wasm/WasmSignature.cpp:77
>>> + void* memory = Signature::operator new (allocatedSize(argumentCount));
>>
>> Other parts of the code use the try* allocators so that wasm can OOM without being sad. It was tryFastCalloc above, we should keep that property here.
>
> Ok.</span >
Actually, Ima keep this as is. Our handling of an argument count limit should make tryMalloc here useless. We should enforce our own limit during module parsing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>