[Webkit-unassigned] [Bug 170028] webkitpy should be able to run API tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170028

--- Comment #5 from Sri Vijayaraghavan <svijayaraghavan at apple.com> ---
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 305233 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305233&action=review
> 
> > Tools/Scripts/webkitpy/tool/steps/runtests.py:65
> > +        if self._options.group == "api":
> 
> I'm not sure if this is quite right. As API tests run together with regular
> ones, marking the EWS queue as "api" doesn't seem to make sense.

This code runs when webkit-patch calls itself using a command such as "webkit-patch build-and-test --test --non-interactive --group=x". What's being checked here is the value of x that was passed, not any property of the queue itself.

The arguments above are generated in PatchAnalysisTask, which will be changed to allow group=api for running the API tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170324/a1d3b760/attachment.html>