<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - webkitpy should be able to run API tests"
href="https://bugs.webkit.org/show_bug.cgi?id=170028#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - webkitpy should be able to run API tests"
href="https://bugs.webkit.org/show_bug.cgi?id=170028">bug 170028</a>
from <span class="vcard"><a class="email" href="mailto:svijayaraghavan@apple.com" title="Sri Vijayaraghavan <svijayaraghavan@apple.com>"> <span class="fn">Sri Vijayaraghavan</span></a>
</span></b>
<pre>(In reply to Alexey Proskuryakov from <a href="show_bug.cgi?id=170028#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=305233&action=diff" name="attach_305233" title="Patch">attachment 305233</a> <a href="attachment.cgi?id=305233&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=305233&action=review">https://bugs.webkit.org/attachment.cgi?id=305233&action=review</a>
>
> > Tools/Scripts/webkitpy/tool/steps/runtests.py:65
> > + if self._options.group == "api":
>
> I'm not sure if this is quite right. As API tests run together with regular
> ones, marking the EWS queue as "api" doesn't seem to make sense.</span >
This code runs when webkit-patch calls itself using a command such as "webkit-patch build-and-test --test --non-interactive --group=x". What's being checked here is the value of x that was passed, not any property of the queue itself.
The arguments above are generated in PatchAnalysisTask, which will be changed to allow group=api for running the API tests.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>