[Webkit-unassigned] [Bug 165670] Add a warning for unused link preloads.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165670

--- Comment #47 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to youenn fablet from comment #44)
> (In reply to Yoav Weiss from comment #42)
> > (In reply to youenn fablet from comment #41)
> > > Comment on attachment 305273 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=305273&action=review
> > > 
> > > > Source/WebCore/page/DOMWindow.h:390
> > > > +    Timer m_unusedPreloadsTimer;
> > > 
> > > Why not having this timer in CachedResourceLoader and letting
> > > DOMWindow/Document notify the cached resource loader when to start/stop its
> > > timer?
> > 
> > I'll move it if you think it's cleaner.
> 
> I think it will avoid leaking some CachedResourceLoader logic in DOMWindow.
> Please let me know if there is something worse when moving the logic.

Much cleaner now with the timer moved. Good call! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170324/75424b32/attachment.html>