<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a warning for unused link preloads."
href="https://bugs.webkit.org/show_bug.cgi?id=165670#c47">Comment # 47</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add a warning for unused link preloads."
href="https://bugs.webkit.org/show_bug.cgi?id=165670">bug 165670</a>
from <span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span></b>
<pre>(In reply to youenn fablet from <a href="show_bug.cgi?id=165670#c44">comment #44</a>)
<span class="quote">> (In reply to Yoav Weiss from <a href="show_bug.cgi?id=165670#c42">comment #42</a>)
> > (In reply to youenn fablet from <a href="show_bug.cgi?id=165670#c41">comment #41</a>)
> > > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=305273&action=diff" name="attach_305273" title="Patch">attachment 305273</a> <a href="attachment.cgi?id=305273&action=edit" title="Patch">[details]</a></span>
> > > Patch
> > >
> > > View in context:
> > > <a href="https://bugs.webkit.org/attachment.cgi?id=305273&action=review">https://bugs.webkit.org/attachment.cgi?id=305273&action=review</a>
> > >
> > > > Source/WebCore/page/DOMWindow.h:390
> > > > + Timer m_unusedPreloadsTimer;
> > >
> > > Why not having this timer in CachedResourceLoader and letting
> > > DOMWindow/Document notify the cached resource loader when to start/stop its
> > > timer?
> >
> > I'll move it if you think it's cleaner.
>
> I think it will avoid leaking some CachedResourceLoader logic in DOMWindow.
> Please let me know if there is something worse when moving the logic.</span >
Much cleaner now with the timer moved. Good call! :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>