[Webkit-unassigned] [Bug 169701] Fix unit test and bug fix for 'pull-os-versions.js' script.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169701

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 304561
  --> https://bugs.webkit.org/attachment.cgi?id=304561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304561&action=review

> Websites/perf.webkit.org/ChangeLog:9
> +        Fix 'pull-os-versions.js' does not fetch new builds and report.

This sentence has two verbs.
Fix the bug that 'pull-os-versions.js' does not fetch new builds and report?

> Websites/perf.webkit.org/tools/pull-os-versions.js:34
> +        return fetchers.reduce((promise, fetcher) => {
> +            return promise.then(fetcher.fetchAndReportNewBuilds());
> +        }, Promise.resolve());

Are you sure you really meant to call chain the promise returned by fetcher.fetchAndReportNewBuilds()?
If you want to call each promise in sentience, you need to do:
(promise, fetcher) => {
    return promise.then(() => fetcher.fetchAndReportNewBuilds());
}

Perhaps you want to create a new helper function that sequentialize promises?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170316/2c98e5f2/attachment.html>