<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix unit test and bug fix for 'pull-os-versions.js' script."
href="https://bugs.webkit.org/show_bug.cgi?id=169701#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix unit test and bug fix for 'pull-os-versions.js' script."
href="https://bugs.webkit.org/show_bug.cgi?id=169701">bug 169701</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=304561&action=diff" name="attach_304561" title="Patch">attachment 304561</a> <a href="attachment.cgi?id=304561&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=304561&action=review">https://bugs.webkit.org/attachment.cgi?id=304561&action=review</a>
<span class="quote">> Websites/perf.webkit.org/ChangeLog:9
> + Fix 'pull-os-versions.js' does not fetch new builds and report.</span >
This sentence has two verbs.
Fix the bug that 'pull-os-versions.js' does not fetch new builds and report?
<span class="quote">> Websites/perf.webkit.org/tools/pull-os-versions.js:34
> + return fetchers.reduce((promise, fetcher) => {
> + return promise.then(fetcher.fetchAndReportNewBuilds());
> + }, Promise.resolve());</span >
Are you sure you really meant to call chain the promise returned by fetcher.fetchAndReportNewBuilds()?
If you want to call each promise in sentience, you need to do:
(promise, fetcher) => {
return promise.then(() => fetcher.fetchAndReportNewBuilds());
}
Perhaps you want to create a new helper function that sequentialize promises?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>