[Webkit-unassigned] [Bug 153911] Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 14 21:41:59 PDT 2017


Devin Rousso <webkit at devinrousso.com> changed:

           What    |Removed                     |Added
 Attachment #304455|review?                     |review+
              Flags|                            |

--- Comment #13 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 304455
  --> https://bugs.webkit.org/attachment.cgi?id=304455
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=304455&action=review


> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:198
> +            object.callFunction(inspectedPage_node_collectPrototypes, undefined, false, nodePrototypesReady.bind(this));

NIT: use `const` variables for `undefined` and `false`

const args = undefined;
const generatePreview = false;

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:236
> +                if (title.match(/Prototype$/)) {

NIT: I think it's slightly faster to use `/Prototype$/.test(title)`.

> Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js:240
> +    setPrototypeNameOverride(override)

Any reason not to use a setter?  Or do you want this to be more of a "mode change" in the way it's read (meaning it's not just a value but instead it's a fully fledged function and will do stuff) ?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170315/9c325745/attachment.html>

More information about the webkit-unassigned mailing list