<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:webkit@devinrousso.com" title="Devin Rousso <webkit@devinrousso.com>"> <span class="fn">Devin Rousso</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors"
href="https://bugs.webkit.org/show_bug.cgi?id=153911">bug 153911</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #304455 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors"
href="https://bugs.webkit.org/show_bug.cgi?id=153911#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors"
href="https://bugs.webkit.org/show_bug.cgi?id=153911">bug 153911</a>
from <span class="vcard"><a class="email" href="mailto:webkit@devinrousso.com" title="Devin Rousso <webkit@devinrousso.com>"> <span class="fn">Devin Rousso</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=304455&action=diff" name="attach_304455" title="[PATCH] Proposed Fix">attachment 304455</a> <a href="attachment.cgi?id=304455&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=304455&action=review">https://bugs.webkit.org/attachment.cgi?id=304455&action=review</a>
r=me
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:198
> + object.callFunction(inspectedPage_node_collectPrototypes, undefined, false, nodePrototypesReady.bind(this));</span >
NIT: use `const` variables for `undefined` and `false`
const args = undefined;
const generatePreview = false;
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:236
> + if (title.match(/Prototype$/)) {</span >
NIT: I think it's slightly faster to use `/Prototype$/.test(title)`.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js:240
> + setPrototypeNameOverride(override)</span >
Any reason not to use a setter? Or do you want this to be more of a "mode change" in the way it's read (meaning it's not just a value but instead it's a fully fledged function and will do stuff) ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>