[Webkit-unassigned] [Bug 169610] New:=?UTF-8?Q?=20Remove=20redundant=20check=20for=20=E2=80=9CfirstLine=E2=80=9D=20in=20RenderBlock?=::lineHeight()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169610

            Bug ID: 169610
           Summary: Remove redundant check for “firstLine” in
                    RenderBlock::lineHeight()
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

Found by Coverity Scan:

webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2922: cond_const: Condition "firstLine", taking true branch. Now the value of "firstLine" is equal to 1.
webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2923: const: At condition "firstLine", the value of "firstLine" must be equal to 1.
webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2923: dead_error_condition: The condition "firstLine" must be true.
webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2923: dead_error_line: Execution cannot reach the expression "this->style()" inside this statement: "s = (firstLine ? this->firs...".
# 2921| 
# 2922| if (firstLine && view().usesFirstLineRules()) {
# 2923|-> auto& s = firstLine ? firstLineStyle() : style();
# 2924| if (&s != &style())
# 2925| return s.computedLineHeight();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170314/7be3358f/attachment-0001.html>