<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove redundant check for “firstLine” in RenderBlock::lineHeight()"
href="https://bugs.webkit.org/show_bug.cgi?id=169610">169610</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Remove redundant check for “firstLine” in RenderBlock::lineHeight()
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>Other
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebCore Misc.
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>aperez@igalia.com
</td>
</tr></table>
<p>
<div>
<pre>Found by Coverity Scan:
webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2922: cond_const: Condition "firstLine", taking true branch. Now the value of "firstLine" is equal to 1.
webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2923: const: At condition "firstLine", the value of "firstLine" must be equal to 1.
webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2923: dead_error_condition: The condition "firstLine" must be true.
webkitgtk-2.14.5/Source/WebCore/rendering/RenderBlock.cpp:2923: dead_error_line: Execution cannot reach the expression "this->style()" inside this statement: "s = (firstLine ? this->firs...".
# 2921|
# 2922| if (firstLine && view().usesFirstLineRules()) {
# 2923|-> auto& s = firstLine ? firstLineStyle() : style();
# 2924| if (&s != &style())
# 2925| return s.computedLineHeight();</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>