[Webkit-unassigned] [Bug 169533] New: [GTK] Unbreak build with GTK+ >=3.20 after r213772

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169533

            Bug ID: 169533
           Summary: [GTK] Unbreak build with GTK+ >=3.20 after r213772
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: bugs-noreply at webkitgtk.org

The EWS didn't catch the build failure because we use use GTK+ 3.16
in the Jhbuild. After submitting the patch for bug #169526 I made
a build with the system's GTK+ and found this build failure:

 Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:571:49: error: cannot convert ‘GtkFileChooserNative* {aka _GtkFileChooserNative*}’
  to ‘GtkNativeDialog* {aka _GtkNativeDialog*}’ for argument ‘1’ to ‘void gtk_native_dialog_set_modal(GtkNativeDialog*, gboolean)’
         gtk_native_dialog_set_modal(dialog, TRUE);
                                                 ^
The fix is straightforward and involves only adding a missing cast,
I'm uploading a patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170312/50b96a35/attachment.html>