<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Unbreak build with GTK+ >=3.20 after r213772"
href="https://bugs.webkit.org/show_bug.cgi?id=169533">169533</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[GTK] Unbreak build with GTK+ >=3.20 after r213772
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>Other
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebKit Gtk
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>aperez@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>bugs-noreply@webkitgtk.org
</td>
</tr></table>
<p>
<div>
<pre>The EWS didn't catch the build failure because we use use GTK+ 3.16
in the Jhbuild. After submitting the patch for <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] File choosers should run as modal by default if possible"
href="show_bug.cgi?id=169526">bug #169526</a> I made
a build with the system's GTK+ and found this build failure:
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:571:49: error: cannot convert ‘GtkFileChooserNative* {aka _GtkFileChooserNative*}’
to ‘GtkNativeDialog* {aka _GtkNativeDialog*}’ for argument ‘1’ to ‘void gtk_native_dialog_set_modal(GtkNativeDialog*, gboolean)’
gtk_native_dialog_set_modal(dialog, TRUE);
^
The fix is straightforward and involves only adding a missing cast,
I'm uploading a patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>