[Webkit-unassigned] [Bug 149157] Allow the page to render before <link> stylesheet tags in body

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149157

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303826|review?                     |review+
              Flags|                            |

--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 303826
  --> https://bugs.webkit.org/attachment.cgi?id=303826
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303826&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1575
> +    // Style is non-final if the element has a pending stylesheet before it. We end up with renderers with such styles if a script
> +    // forces renderer construction by querying something layout dependent.

Is this comment accurate with <link rel="stylesheet"> in the body? Won't we force renderer construction anyway?

> Source/WebCore/style/StyleTreeResolver.cpp:171
> +        m_document.setHasNodesWithNonFinalStyle();

Wehre is this cleared? I see no calls to m_document.setHasNodesWithNonFinalStyle(false)

> Source/WebCore/style/StyleTreeResolver.cpp:184
> +        m_document.setHasNodesWithNonFinalStyle();

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170308/2d504bc2/attachment.html>