<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow the page to render before <link> stylesheet tags in body"
href="https://bugs.webkit.org/show_bug.cgi?id=149157">bug 149157</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #303826 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow the page to render before <link> stylesheet tags in body"
href="https://bugs.webkit.org/show_bug.cgi?id=149157#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Allow the page to render before <link> stylesheet tags in body"
href="https://bugs.webkit.org/show_bug.cgi?id=149157">bug 149157</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303826&action=diff" name="attach_303826" title="patch">attachment 303826</a> <a href="attachment.cgi?id=303826&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303826&action=review">https://bugs.webkit.org/attachment.cgi?id=303826&action=review</a>
<span class="quote">> Source/WebCore/rendering/RenderBlock.cpp:1575
> + // Style is non-final if the element has a pending stylesheet before it. We end up with renderers with such styles if a script
> + // forces renderer construction by querying something layout dependent.</span >
Is this comment accurate with <link rel="stylesheet"> in the body? Won't we force renderer construction anyway?
<span class="quote">> Source/WebCore/style/StyleTreeResolver.cpp:171
> + m_document.setHasNodesWithNonFinalStyle();</span >
Wehre is this cleared? I see no calls to m_document.setHasNodesWithNonFinalStyle(false)
<span class="quote">> Source/WebCore/style/StyleTreeResolver.cpp:184
> + m_document.setHasNodesWithNonFinalStyle();</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>