[Webkit-unassigned] [Bug 164689] [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164689

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #5)
> > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:265
> > +        for (int i = 0; i < unpreparedFallbacks.get()->nfont; i++) {
> 
> unsigned

Nope, because FcFontSet::nfont is an int.

> > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:267
> > +            FcPattern* pattern = FcFontRenderPrepare(nullptr, m_pattern.get(), unpreparedFallbacks.get()->fonts[i]);
> > +            FcFontSetAdd(m_fallbacks.get(), pattern);
> 
> This could probably be just one line

OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170307/22ae5d26/attachment-0001.html>