<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns"
href="https://bugs.webkit.org/show_bug.cgi?id=164689#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns"
href="https://bugs.webkit.org/show_bug.cgi?id=164689">bug 164689</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164689#c5">comment #5</a>)
<span class="quote">> > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:265
> > + for (int i = 0; i < unpreparedFallbacks.get()->nfont; i++) {
>
> unsigned</span >
Nope, because FcFontSet::nfont is an int.
<span class="quote">> > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:267
> > + FcPattern* pattern = FcFontRenderPrepare(nullptr, m_pattern.get(), unpreparedFallbacks.get()->fonts[i]);
> > + FcFontSetAdd(m_fallbacks.get(), pattern);
>
> This could probably be just one line</span >
OK.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>