[Webkit-unassigned] [Bug 169278] [GTK] Use GtkFileChooserNative for open/save dialogs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 7 07:00:29 PST 2017


--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
(In reply to comment #1)
> Looks pretty easy, just need to update webkitWebViewRunFileChooser in
> WebKitWebView.cpp.
> Looks like it has no support for MIME types filter, though? That's a shame.

I am already making a test build with locally with the needed changes
applied; I will attach it to the bug soon.

Regarding the filters, from the documentation (linked in the bug
description) my interpretation is that:

 - MIME-type based filters are supported by the Flatpak portal chooser
   implementation. We are only using this kind of filter in WebKitGTK+

 - No filters at all are supported in the Windows implementation. When
   using filters GtkFileChooserNative automatically falls-back to using
   GtkFileChooserDialog. Not like we care right now, as we are lacking
   in the Windows support department, but if somebody made WebKitGTK+
   work in Windows, it seems reasonable to use GtkFileChooserNative and
   let it trigger the fall-back code path when needed.

TL;DR: We will be fine as we are only using MIME-type based filters.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170307/72ce0ec2/attachment.html>

More information about the webkit-unassigned mailing list