<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GtkFileChooserNative for open/save dialogs"
href="https://bugs.webkit.org/show_bug.cgi?id=169278#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GtkFileChooserNative for open/save dialogs"
href="https://bugs.webkit.org/show_bug.cgi?id=169278">bug 169278</a>
from <span class="vcard"><a class="email" href="mailto:aperez@igalia.com" title="Adrian Perez <aperez@igalia.com>"> <span class="fn">Adrian Perez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=169278#c1">comment #1</a>)
<span class="quote">> Looks pretty easy, just need to update webkitWebViewRunFileChooser in
> WebKitWebView.cpp.
>
> Looks like it has no support for MIME types filter, though? That's a shame.</span >
I am already making a test build with locally with the needed changes
applied; I will attach it to the bug soon.
Regarding the filters, from the documentation (linked in the bug
description) my interpretation is that:
- MIME-type based filters are supported by the Flatpak portal chooser
implementation. We are only using this kind of filter in WebKitGTK+
(good!).
- No filters at all are supported in the Windows implementation. When
using filters GtkFileChooserNative automatically falls-back to using
GtkFileChooserDialog. Not like we care right now, as we are lacking
in the Windows support department, but if somebody made WebKitGTK+
work in Windows, it seems reasonable to use GtkFileChooserNative and
let it trigger the fall-back code path when needed.
TL;DR: We will be fine as we are only using MIME-type based filters.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>