[Webkit-unassigned] [Bug 164689] [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164689

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294643|review?                     |review+
              Flags|                            |

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 294643
  --> https://bugs.webkit.org/attachment.cgi?id=294643
[FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns

View in context: https://bugs.webkit.org/attachment.cgi?id=294643&action=review

> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:265
> +        for (int i = 0; i < unpreparedFallbacks.get()->nfont; i++) {

unsigned

> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:267
> +            FcPattern* pattern = FcFontRenderPrepare(nullptr, m_pattern.get(), unpreparedFallbacks.get()->fonts[i]);
> +            FcFontSetAdd(m_fallbacks.get(), pattern);

This could probably be just one line

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170307/92486f32/attachment.html>