<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns"
href="https://bugs.webkit.org/show_bug.cgi?id=164689">bug 164689</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #294643 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns"
href="https://bugs.webkit.org/show_bug.cgi?id=164689#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns"
href="https://bugs.webkit.org/show_bug.cgi?id=164689">bug 164689</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294643&action=diff" name="attach_294643" title="[FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns">attachment 294643</a> <a href="attachment.cgi?id=294643&action=edit" title="[FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns">[details]</a></span>
[FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294643&action=review">https://bugs.webkit.org/attachment.cgi?id=294643&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:265
> + for (int i = 0; i < unpreparedFallbacks.get()->nfont; i++) {</span >
unsigned
<span class="quote">> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:267
> + FcPattern* pattern = FcFontRenderPrepare(nullptr, m_pattern.get(), unpreparedFallbacks.get()->fonts[i]);
> + FcFontSetAdd(m_fallbacks.get(), pattern);</span >
This could probably be just one line</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>