[Webkit-unassigned] [Bug 169171] Perf and layout test results should report using correct scm revision

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169171

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 303399
  --> https://bugs.webkit.org/attachment.cgi?id=303399
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303399&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:279
> +        # If `revision` is composed of 0-6 digits, assume SVN revision. Else, assume git hash
> +        svn_revision_regex = re.compile('^[1-9]\d{0,5}$')

This is a rather dangerous assumption. A git hash especially not the full length one could entirely consist of digits.

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:-289
>      def timestamp_of_revision(self, path, revision):
> -        git_log = self._most_recent_log_matching('git-svn-id:.*@%s' % revision, path)

I think it's better to add a new version of this function which gets the timestamp for the "native" revision.

> Tools/Scripts/webkitpy/common/checkout/scm/scm.py:72
> +                                           cwd=cwd,

Nit: This is wrong indentation.
Per WebKit's style guideline, these text should be exactly 4 spaces on the right of the beginning of "return self._executive..."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170306/dd01fa9f/attachment.html>