<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Perf and layout test results should report using correct scm revision"
href="https://bugs.webkit.org/show_bug.cgi?id=169171#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Perf and layout test results should report using correct scm revision"
href="https://bugs.webkit.org/show_bug.cgi?id=169171">bug 169171</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303399&action=diff" name="attach_303399" title="Patch">attachment 303399</a> <a href="attachment.cgi?id=303399&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303399&action=review">https://bugs.webkit.org/attachment.cgi?id=303399&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/common/checkout/scm/git.py:279
> + # If `revision` is composed of 0-6 digits, assume SVN revision. Else, assume git hash
> + svn_revision_regex = re.compile('^[1-9]\d{0,5}$')</span >
This is a rather dangerous assumption. A git hash especially not the full length one could entirely consist of digits.
<span class="quote">> Tools/Scripts/webkitpy/common/checkout/scm/git.py:-289
> def timestamp_of_revision(self, path, revision):
> - git_log = self._most_recent_log_matching('git-svn-id:.*@%s' % revision, path)</span >
I think it's better to add a new version of this function which gets the timestamp for the "native" revision.
<span class="quote">> Tools/Scripts/webkitpy/common/checkout/scm/scm.py:72
> + cwd=cwd,</span >
Nit: This is wrong indentation.
Per WebKit's style guideline, these text should be exactly 4 spaces on the right of the beginning of "return self._executive..."</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>