[Webkit-unassigned] [Bug 165225] UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #45 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 303318
  --> https://bugs.webkit.org/attachment.cgi?id=303318
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303318&action=review

Just minor nits and ChangeLog formatting issues -- the rest of the patch looks good.

> Source/WebKit2/ChangeLog:6
> +        The problem happens on an iPhone with a WKWebView inside a view controller presented modally. If the user selects an HTML file input 

Please move this description down below the "Reviewed by" line. The ordering of things should be:

```
<Title of the bug>
<bug URL>
<rdar link, if any>

Reviewed by <reviewer name>

<description of problem and how the change fixes it>

<list of individial methods changed, with inline comments if needed>
```

You may refer to an example, such as https://trac.webkit.org/changeset/213348/trunk/LayoutTests/ChangeLog, for what a ChangeLog entry should look like.

> Source/WebKit2/ChangeLog:13
> +        https://bugs.webkit.org/show_bug.cgi?id=165225

Please remove this duplicated bug URL

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:391
> +    // Dismiss any viewController that is being presented. This works for all types of view controllers, popovers, etc.

As Tim suggested earlier, please replace "viewController" with "view controller".

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392
> +    // If there is any kind of viewController presented on this view, it will be removed. 

Please replace "viewController" with "view controller" here too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170303/5255cec6/attachment.html>