<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225#c45">Comment # 45</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225">bug 165225</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303318&action=diff" name="attach_303318" title="Patch">attachment 303318</a> <a href="attachment.cgi?id=303318&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303318&action=review">https://bugs.webkit.org/attachment.cgi?id=303318&action=review</a>
Just minor nits and ChangeLog formatting issues -- the rest of the patch looks good.
<span class="quote">> Source/WebKit2/ChangeLog:6
> + The problem happens on an iPhone with a WKWebView inside a view controller presented modally. If the user selects an HTML file input </span >
Please move this description down below the "Reviewed by" line. The ordering of things should be:
```
<Title of the bug>
<bug URL>
<rdar link, if any>
Reviewed by <reviewer name>
<description of problem and how the change fixes it>
<list of individial methods changed, with inline comments if needed>
```
You may refer to an example, such as <a href="https://trac.webkit.org/changeset/213348/trunk/LayoutTests/ChangeLog">https://trac.webkit.org/changeset/213348/trunk/LayoutTests/ChangeLog</a>, for what a ChangeLog entry should look like.
<span class="quote">> Source/WebKit2/ChangeLog:13
> + <a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="show_bug.cgi?id=165225">https://bugs.webkit.org/show_bug.cgi?id=165225</a></span >
Please remove this duplicated bug URL
<span class="quote">> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:391
> + // Dismiss any viewController that is being presented. This works for all types of view controllers, popovers, etc.</span >
As Tim suggested earlier, please replace "viewController" with "view controller".
<span class="quote">> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392
> + // If there is any kind of viewController presented on this view, it will be removed. </span >
Please replace "viewController" with "view controller" here too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>