[Webkit-unassigned] [Bug 165225] UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #43 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 303282
  --> https://bugs.webkit.org/attachment.cgi?id=303282
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303282&action=review

Please account for Tim's review feedback -- the rest of the patch looks good!

> Source/WebKit2/ChangeLog:8
> +        * UIProcess/ios/forms/WKFileUploadPanel.mm:

As Tim suggested earlier, you should include a couple of sentences here describing what the problem was, and how this change addresses the problem. You can refer to https://trac.webkit.org/changeset/213304 for a great example of what a ChangeLog should look like.

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:391
> +    // Dismiss any viewController that is being presented. This works for all types of viewcontrollers , popovers, etc.

As Tim suggested earlier, please replace "viewController" with "view controller". There is also an extra space before ", popovers" that you should remove.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170303/8d129ef1/attachment.html>