<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225#c43">Comment # 43</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225">bug 165225</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303282&action=diff" name="attach_303282" title="Patch">attachment 303282</a> <a href="attachment.cgi?id=303282&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303282&action=review">https://bugs.webkit.org/attachment.cgi?id=303282&action=review</a>
Please account for Tim's review feedback -- the rest of the patch looks good!
<span class="quote">> Source/WebKit2/ChangeLog:8
> + * UIProcess/ios/forms/WKFileUploadPanel.mm:</span >
As Tim suggested earlier, you should include a couple of sentences here describing what the problem was, and how this change addresses the problem. You can refer to <a href="https://trac.webkit.org/changeset/213304">https://trac.webkit.org/changeset/213304</a> for a great example of what a ChangeLog should look like.
<span class="quote">> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:391
> + // Dismiss any viewController that is being presented. This works for all types of viewcontrollers , popovers, etc.</span >
As Tim suggested earlier, please replace "viewController" with "view controller". There is also an extra space before ", popovers" that you should remove.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>