[Webkit-unassigned] [Bug 165225] UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303279|review?                     |review+
              Flags|                            |

--- Comment #41 from Tim Horton <thorton at apple.com> ---
Comment on attachment 303279
  --> https://bugs.webkit.org/attachment.cgi?id=303279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303279&action=review

> Source/WebKit2/ChangeLog:13
> +        (-[WKFileUploadPanel _cancel]):
> +        (-[WKFileUploadPanel dismiss]):
> +        (-[WKFileUploadPanel _showDocumentPickerMenu]):
> +        (-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):
> +        (-[WKFileUploadPanel _presentForCurrentInterfaceIdiom:]): Deleted.

Ideally this would explain why you're doing what you're doing.

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:391
> +    // Dismiss any viewController that is being presented. This works for all types of viewcontrollers , popovers, etc.

"view controllers, popovers, etc." (spaces!) Also, each mention of viewController in this comment should probably be "view controller"

>> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:396
>> +    // Clean up any pointers
> 
> Nit - I don't think this comment adds much.

Yep, this is a "what" comment, not a "why" comment, so it should go away.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170303/ccd004da/attachment.html>