<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225">bug 165225</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #303279 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225#c41">Comment # 41</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225">bug 165225</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303279&action=diff" name="attach_303279" title="Patch">attachment 303279</a> <a href="attachment.cgi?id=303279&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303279&action=review">https://bugs.webkit.org/attachment.cgi?id=303279&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:13
> + (-[WKFileUploadPanel _cancel]):
> + (-[WKFileUploadPanel dismiss]):
> + (-[WKFileUploadPanel _showDocumentPickerMenu]):
> + (-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):
> + (-[WKFileUploadPanel _presentForCurrentInterfaceIdiom:]): Deleted.</span >
Ideally this would explain why you're doing what you're doing.
<span class="quote">> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:391
> + // Dismiss any viewController that is being presented. This works for all types of viewcontrollers , popovers, etc.</span >
"view controllers, popovers, etc." (spaces!) Also, each mention of viewController in this comment should probably be "view controller"
<span class="quote">>> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:396
>> + // Clean up any pointers
>
> Nit - I don't think this comment adds much.</span >
Yep, this is a "what" comment, not a "why" comment, so it should go away.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>