[Webkit-unassigned] [Bug 165225] UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #23 from Brad Wright <bwright2 at apple.com> ---
(In reply to comment #22)
> Comment on attachment 303114 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303114&action=review
> 
> > Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:-389
> > -    [self _dismissDisplayAnimated:NO];
> 
> _dismissDisplayAnimated: handles dismissing the _presentationPopover. If we
> aren't going to go through _dismissDisplayAnimated: here, we need to still
> dismissPopoverAnimated: on the _presentationPopover.

The original dismiss had animated set to NO.  I tested this condition on the iPad with the popover displayed, and it correctly removed the popover from the screen.  Therefore, I believe that calling dismissPopoverAnimated is not needed under this condition, since animated is always set to NO.
> 
> > Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392
> > +    UIViewController *presentedVC = [UIViewController _viewControllerForFullScreenPresentationFromView:_view];
> 
> WebKit style guidelines (https://webkit.org/code-style-guidelines/)
> recommend using full variable names rather than abbreviations, so
> presentedVC should be presentedViewController.

Sounds good, I'll change that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/6a0f69fa/attachment.html>