<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed."
href="https://bugs.webkit.org/show_bug.cgi?id=165225">bug 165225</a>
from <span class="vcard"><a class="email" href="mailto:bwright2@apple.com" title="Brad Wright <bwright2@apple.com>"> <span class="fn">Brad Wright</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=165225#c22">comment #22</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=303114&action=diff" name="attach_303114" title="Patch">attachment 303114</a> <a href="attachment.cgi?id=303114&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=303114&action=review">https://bugs.webkit.org/attachment.cgi?id=303114&action=review</a>
>
> > Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:-389
> > - [self _dismissDisplayAnimated:NO];
>
> _dismissDisplayAnimated: handles dismissing the _presentationPopover. If we
> aren't going to go through _dismissDisplayAnimated: here, we need to still
> dismissPopoverAnimated: on the _presentationPopover.</span >
The original dismiss had animated set to NO. I tested this condition on the iPad with the popover displayed, and it correctly removed the popover from the screen. Therefore, I believe that calling dismissPopoverAnimated is not needed under this condition, since animated is always set to NO.
<span class="quote">>
> > Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392
> > + UIViewController *presentedVC = [UIViewController _viewControllerForFullScreenPresentationFromView:_view];
>
> WebKit style guidelines (<a href="https://webkit.org/code-style-guidelines/">https://webkit.org/code-style-guidelines/</a>)
> recommend using full variable names rather than abbreviations, so
> presentedVC should be presentedViewController.</span >
Sounds good, I'll change that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>