[Webkit-unassigned] [Bug 169019] [GTK] fast/canvas/canvas-createPattern-video-loading.html makes its subsequent test timeout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 1 07:40:01 PST 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #303057|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 303057
  --> https://bugs.webkit.org/attachment.cgi?id=303057

View in context: https://bugs.webkit.org/attachment.cgi?id=303057&action=review

As you're writing the code, it should be affecting other private players such as the WebRTC and the MSE ones. Please ensure that no tests are broken

> Source/WebCore/ChangeLog:8
> +        The timeout happens normally when the media player is and the pipeline state is set to NULL. The call to

This first sentence does not make too much sense to me.

> Source/WebCore/ChangeLog:10
> +        happens with the smaple mutex used by VideoRenderRequestScheduler. VideoRenderRequestScheduler::requestRender()

smaple -> sample.

> Source/WebCore/ChangeLog:21
> +        ~MediaPlayerPrivateGStreamerBase and ensure the draw timer and mutex is proplery cleaned up before.

is proplery -> are properly

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/53475c20/attachment.html>

More information about the webkit-unassigned mailing list