<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [GTK] fast/canvas/canvas-createPattern-video-loading.html makes its subsequent test timeout"
href="https://bugs.webkit.org/show_bug.cgi?id=169019">bug 169019</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #303057 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [GTK] fast/canvas/canvas-createPattern-video-loading.html makes its subsequent test timeout"
href="https://bugs.webkit.org/show_bug.cgi?id=169019#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [GTK] fast/canvas/canvas-createPattern-video-loading.html makes its subsequent test timeout"
href="https://bugs.webkit.org/show_bug.cgi?id=169019">bug 169019</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=303057&action=diff" name="attach_303057" title="Patch">attachment 303057</a> <a href="attachment.cgi?id=303057&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=303057&action=review">https://bugs.webkit.org/attachment.cgi?id=303057&action=review</a>
As you're writing the code, it should be affecting other private players such as the WebRTC and the MSE ones. Please ensure that no tests are broken
<span class="quote">> Source/WebCore/ChangeLog:8
> + The timeout happens normally when the media player is and the pipeline state is set to NULL. The call to</span >
This first sentence does not make too much sense to me.
<span class="quote">> Source/WebCore/ChangeLog:10
> + happens with the smaple mutex used by VideoRenderRequestScheduler. VideoRenderRequestScheduler::requestRender()</span >
smaple -> sample.
<span class="quote">> Source/WebCore/ChangeLog:21
> + ~MediaPlayerPrivateGStreamerBase and ensure the draw timer and mutex is proplery cleaned up before.</span >
is proplery -> are properly</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>