[Webkit-unassigned] [Bug 173889] [Win] Build JSCOnly on Windows with clang-cl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173889

--- Comment #6 from Stephan Szabo <stephan.szabo at sony.com> ---
(In reply to Konstantin Tokarev from comment #4)
> Comment on attachment 313956 [details]
> Patch to build jsc-only with clang-cl toolset - combined clang-cl/gcc/clang4
> option
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313956&action=review
> 
> > Source/cmake/OptionsCommon.cmake:57
> > +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing -fno-rtti")
> 
> Don't duplicate these lines


> > Source/cmake/OptionsCommon.cmake:58
> > +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++1y")
> 
> Can clang-cl accept -std=c++1y? If yes, it should just add a few flags to
> those set in the common COMPILER_IS_GCC_OR_CLANG block

Unfortunately, no, -std is considered an unknown argument.
(In reply to Konstantin Tokarev from comment #4)
> Comment on attachment 313956 [details]
> Patch to build jsc-only with clang-cl toolset - combined clang-cl/gcc/clang4
> option
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313956&action=review
> 
> > Source/cmake/OptionsCommon.cmake:57
> > +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing -fno-rtti")
> 
> Don't duplicate these lines

I'm sorry, I'm not sure what you mean here. Is it because we're doing -fno-strict-aliasing in both branches? We aren't passing -fno-exceptions or -fno-rtti in the clang-cl case, but it'd be easy to separate the common one out if that seems better.

> > Source/cmake/OptionsCommon.cmake:58
> > +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++1y")
> 
> Can clang-cl accept -std=c++1y? If yes, it should just add a few flags to
> those set in the common COMPILER_IS_GCC_OR_CLANG block

Unfortunately, no, -std is an unknown argument for clang-cl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170628/3497bc74/attachment.html>