[Webkit-unassigned] [Bug 173889] [Win] Build JSCOnly on Windows with clang-cl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173889

--- Comment #5 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 313956
  --> https://bugs.webkit.org/attachment.cgi?id=313956
Patch to build jsc-only with clang-cl toolset - combined clang-cl/gcc/clang4 option

View in context: https://bugs.webkit.org/attachment.cgi?id=313956&action=review

>> Source/cmake/OptionsCommon.cmake:57
>> +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing -fno-rtti")
> 
> Don't duplicate these lines

These were duplicated from above. I'm guessing because those options are never going to change.

>> Source/cmake/OptionsCommon.cmake:58
>> +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++1y")
> 
> Can clang-cl accept -std=c++1y? If yes, it should just add a few flags to those set in the common COMPILER_IS_GCC_OR_CLANG block

With clang-cl it attempts to use the cl options where applicable such as https://blogs.msdn.microsoft.com/vcblog/2016/06/07/standards-version-switches-in-the-compiler/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170628/6c7d6fae/attachment.html>