[Webkit-unassigned] [Bug 173714] Use window.internals instead of overridePreference to set WebCore settings in tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173714

--- Comment #27 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
(In reply to Frédéric Wang (:fredw) from comment #26)
> More analysis on the remaining properties:
> 
> These have special handling in
> InjectedBundle::overrideBoolPreferenceForTestRunner and do not correspond to
> a WebCore settings ; I wonder if we could extend Internal.idl to expose them:
> WebKitTabToLinksPreferenceKey
> WebKit2AsynchronousPluginInitializationEnabled
> WebKit2AsynchronousPluginInitializationEnabledForAllPlugins
> 
> This maps to some setters on Settings.h but not to a settings in Setting.in
> ; I wonder if we could extend Internal.idl to expose them:
> WebKitDisplayImagesKey => LoadsImagesAutomatically
> WebKitJavaScriptEnabled => ScriptEnabled
> WebKitUsesPageCachePreferenceKey => UsesPageCache

Some of these need to be set before the test starts loading, presumably (you can't run script to disable JS in a sensible way).

Our technique for such behaviors is test headers, see updateTestOptionsFromTestHeader() in WTR.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170623/f5f11fa0/attachment.html>