[Webkit-unassigned] [Bug 173714] Use window.internals instead of overridePreference to set WebCore settings in tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173714

--- Comment #26 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
More analysis on the remaining properties:

These have special handling in InjectedBundle::overrideBoolPreferenceForTestRunner and do not correspond to a WebCore settings ; I wonder if we could extend Internal.idl to expose them:
WebKitTabToLinksPreferenceKey
WebKit2AsynchronousPluginInitializationEnabled
WebKit2AsynchronousPluginInitializationEnabledForAllPlugins

This maps to some setters on Settings.h but not to a settings in Setting.in ; I wonder if we could extend Internal.idl to expose them:
WebKitDisplayImagesKey => LoadsImagesAutomatically
WebKitJavaScriptEnabled => ScriptEnabled
WebKitUsesPageCachePreferenceKey => UsesPageCache

These seem to be WebKit 1 preferences:
WebKitDefaultFontSize
WebKitDefaultTextEncodingName
WebKitMinimumFontSize
WebKitShouldInvertColors
WebKitStorageBlockingPolicy

WebKitCSSRegionsEnabled is only used in fast/regions/region-leak-js-information-when-disabled-at-runtime.html, but it is commented out. Anyway, it seems the test is no longer relevant after https://trac.webkit.org/changeset/200524/webkit

WebKitHiddenPageDOMTimerThrottlingEnabled is used in ./fast/dom/timer-throttling-hidden-page-non-nested.html and ./fast/dom/timer-throttling-hidden-page.html ; for some reason it is separated from the rest of the boolean settings in InjectedBundle::overrideBoolPreferenceForTestRunner, but it looks like we could do the same replacements as done here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170623/77ef4c23/attachment.html>