[Webkit-unassigned] [Bug 128594] [WK2][WTR] Implement overridePreference() for non-boolean values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 19 14:28:08 PDT 2017


--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to Frédéric Wang (:fredw) from comment #2)
> In bug 171914, I have to disable
> platform/mac/fast/frames/flattening/set-preference.html because
> overridePreference does not support non-boolean values.
> 22:36:46 - smfr : why do you need to use overridePreference?
> 22:36:56 - smfr : tests can just poke at internals.settings
> 22:37:11 - smfr : or is it too late after a test starts?
> 22:41:36 - fredw : I don't remember exactly. I believe internals.settings is
> enough. But other settings in mac/DumpRenderTree.mm and tests set a default
> value via this overridePreference so I thought it would be a bit
> inconsistent.
> 22:43:26 - smfr : i think many tests that use overridePreference pre-date
> internals.settings and could just be converted

I agree with Simon. We should just use internal.settings if what is being toggled is a WebCore::Setting.

overridePreference should be used rarely. I think the only valid case is for WebKit level settings not WebCore settings. Even still those could probably move to something else that executes before the test loads.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170619/a80f7a40/attachment.html>

More information about the webkit-unassigned mailing list