[Webkit-unassigned] [Bug 128594] [WK2][WTR] Implement overridePreference() for non-boolean values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128594

--- Comment #4 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to Joseph Pecoraro from comment #3)
> I agree with Simon. We should just use internal.settings if what is being
> toggled is a WebCore::Setting.
> 
> overridePreference should be used rarely. I think the only valid case is for
> WebKit level settings not WebCore settings. Even still those could probably
> move to something else that executes before the test loads.

OK, I uploaded a tentative patch on bug 173714. After that, the remaining settings are:

WebKit2AsynchronousPluginInitializationEnabled
WebKit2AsynchronousPluginInitializationEnabledForAllPlugins
WebKitAllowDisplayingInsecureContent
WebKitCSSRegionsEnabled
WebKitDefaultTextEncodingName
WebKitDisplayImagesKey
WebKitJavaScriptEnabled
WebKitLoadSiteIconsKey
WebKitShouldInvertColors
WebKitStorageBlockingPolicy
WebKitTabToLinksPreferenceKey
WebKitUsesPageCachePreferenceKey

Also:

WebKitHiddenPageDOMTimerThrottlingEnabled (bug 173713)
WebKitDefaultFontSize, MinimumFontSize (non-boolean, need to add something to Internals.idl to expose them)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170622/286de668/attachment.html>