[Webkit-unassigned] [Bug 173367] WKErrorGetErrorCode should not return the API::Error enum values directly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 14 08:52:20 PDT 2017


--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Alex Christensen from comment #2)
> Comment on attachment 312891 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312891&action=review
> > Source/WebKit2/Shared/API/c/WKErrorRef.cpp:79
> > +    default:
> > +        break;
> Do we need this default?  If we are switching on enum values, a default
> would prevent us from finding the bug of missing one of the enum values. 
> Let's remove the default if we can.

Yes, because not all API::Error values are exposed in the C API.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170614/9374352a/attachment.html>

More information about the webkit-unassigned mailing list