[Webkit-unassigned] [Bug 173367] WKErrorGetErrorCode should not return the API::Error enum values directly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 14 08:47:19 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=173367
Alex Christensen <achristensen at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #312891|review? |review+
Flags| |
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 312891
--> https://bugs.webkit.org/attachment.cgi?id=312891
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=312891&action=review
> Source/WebKit2/Shared/API/c/WKErrorRef.cpp:79
> + default:
> + break;
Do we need this default? If we are switching on enum values, a default would prevent us from finding the bug of missing one of the enum values. Let's remove the default if we can.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170614/2ff8184d/attachment.html>
More information about the webkit-unassigned
mailing list